Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sorting method to fieldpath column of schema tab #6510

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Added sorting method to fieldpath column of schema tab #6510

merged 2 commits into from
Nov 22, 2022

Conversation

Ankit-Keshari-Vituity
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 22, 2022
@github-actions
Copy link

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 42s ⏱️ -27s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 4710711. ± Comparison against base commit 10a31b1.

chriscollins3456
chriscollins3456 reviewed Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried out myself things are looking good!

@jjoyce0510 jjoyce0510 merged commit 7f71b25 into datahub-project:master Nov 22, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@Ankit-Keshari-Vituity @jjoyce0510 @cccs-Dustin
feat(ui): Add sorting method to fieldpath column of schema tab (datah…
98cafe8 
…ub-project#6510)

Co-authored-by: John Joyce <john@acryl.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ankit-Keshari-Vituity @chriscollins3456 @jjoyce0510