Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sql): Add SQL index on createdon field #6522

Merged
merged 3 commits into from
Dec 2, 2022
Merged

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Nov 22, 2022

Adds a MySQL index on the createdon column to allow for faster filtering based on time.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@pedro93 pedro93 added the devops PR or Issue related to DataHub backend & deployment label Nov 22, 2022
@github-actions
Copy link

github-actions bot commented Nov 22, 2022

Unit Test Results (build & test)

621 tests  +250   617 ✔️ +246   15m 44s ⏱️ + 14m 45s
157 suites +  55       4 💤 +    4 
157 files   +  55       0 ±    0 

Results for commit 9473621. ± Comparison against base commit 7f71b25.

♻️ This comment has been updated with latest results.

@jjoyce0510
Copy link
Collaborator

@pedro93 This will only impact new deployments, correct?

@pedro93
Copy link
Collaborator Author

pedro93 commented Nov 22, 2022

@pedro93 This will only impact new deployments, correct?

Yes for MySQL. For the rest the create statement always executes when the setup job runs which is always with our helm chart.

@pedro93 pedro93 merged commit 4f7b5ac into master Dec 2, 2022
@pedro93 pedro93 deleted the ft-add-time-index branch December 2, 2022 09:13
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants