fix(ui) Display duplicate nodes in lineage viz #6526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Nov 22, 2022
| @@ -4,7 +4,7 @@ import { curveBasis } from '@vx/curve'; | |||
| import { LinePath } from '@vx/shape'; | |||
| import { TransformMatrix } from '@vx/zoom/lib/types'; | |||
There was a problem hiding this comment.
Any component with an 'And' in the name makes me sad
jjoyce0510
reviewed
Nov 22, 2022
|
|
||
| return ( | ||
| <LineageEntityNode | ||
| key={`node-${node.data.urn}-${direction}`} | ||
| key={key} |
There was a problem hiding this comment.
Not sure if this is relevant, but is there a way to use a triplet to render the node?
node-node.data.urn-dest.data.urn-direction?
Or is this not really the problem
There was a problem hiding this comment.
yeah so the problem when switching base nodes is we had keys here that weren't unique and we would leave the old base node rendered.
but as far as the general issue of having duplicate nodes and dragging and what not, having some combo like that could certainly work. idk if it's relevant in this specific situation though
jjoyce0510
approved these changes
Nov 23, 2022
added 2 commits
November 23, 2022 15:41
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
gabe-lyons
pushed a commit
to gabe-lyons/datahub
that referenced
this pull request
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous attempt to fix a bug where switching base nodes caused weird duplicates and wonky dragging behavior, we prevented the lineage graph from rendering any duplicates. Turns out some people want to render duplicates in their graph because a singular node could be upstream and downstream of a given entity. This reverts the change to allow duplicates and fixes the base node switching bug by making the
keyon each node unique. I also clean things up a bit and remove an unnecessarydirectionprop being passed.Checklist