feat(models): Adding 'created', 'lastModified' timestamp to Dataset, Container, Dashboard, Chart #6527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsheth2
approved these changes
Nov 23, 2022
|
How would we record the actor who created the resource? Maybe create a variant of AuditStamp which loosens the restriction on actor being required but keeps the other goodies (like impersonator) and use it for the createdAt field? |
|
Actor I didn't want to require. If we can actually get a correct actor (one which lines up with other urns) we'd need to add those fields later on. As for lastModified, it's a good question. We typically used Operation.pdl for this but I think it makes sense to reserve that for more rich details around the operations, and have a separate lastModified stamp here. Let me do this - I'll create a new TimeStamp.pdl that will basically allow the Actor field to be not provided, so the UI knows when we do not have one. |
jjoyce0510
changed the title
5 tasks
jjoyce0510
force-pushed
the
jj--add-created-at-to-models
branch
from
c973e22
to
55e1f25
Compare
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
…Container, Dashboard, Chart (datahub-project#6527)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a 'createdAt' timestamp to Datasets, Containers, DataJobs, DataFlows. This is useful for reporting the native platform created time for data assets when ingesting into DataHub.
We are not using an AuditStamp here because the Actor field inside is required. We do not always know that the actor will be resolvable to an URN for created actions, so we are choosing to omit for now.
Status
Ready for review.
Checklist