fix(ingest): bigquery - missing sqlalchemy dep and row count fix #6553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
jjoyce0510
reviewed
Nov 25, 2022
| @@ -349,8 +349,8 @@ def get_tables_for_dataset( | |||
| ) | |||
| if "last_altered" in table | |||
| else None, | |||
| size_in_bytes=table.bytes if "bytes" in table else None, | |||
| rows_count=table.row_count if "row_count" in table else None, | |||
| size_in_bytes=table.bytes if "bytes" in table.keys() else None, | |||
There was a problem hiding this comment.
why do we need .keys()?
jjoyce0510
reviewed
Nov 25, 2022
| @@ -349,8 +349,8 @@ def get_tables_for_dataset( | |||
| ) | |||
| if "last_altered" in table | |||
| else None, | |||
| size_in_bytes=table.bytes if "bytes" in table else None, | |||
| rows_count=table.row_count if "row_count" in table else None, | |||
| size_in_bytes=table.bytes if "bytes" in table.keys() else None, | |||
There was a problem hiding this comment.
table can't be null as this is return bigquery Row objects from the RowIterator
Unit Test Results (metadata ingestion) 8 files ±0 8 suites ±0 59m 1s ⏱️ -10s For more details on these failures, see this check. Results for commit 5826810. ± Comparison against base commit 7a8e36d. ♻️ This comment has been updated with latest results. |
jjoyce0510
approved these changes
Nov 25, 2022
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist