Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(verions): Update opentelemetry and updates from pr-5239 #6563

Merged
merged 2 commits into from
Nov 29, 2022
Merged

fix(verions): Update opentelemetry and updates from pr-5239 #6563

merged 2 commits into from
Nov 29, 2022

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Nov 28, 2022 •
edited
Loading

Upstream PR matching opentelemetry version with the version used in build.gradle.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Nov 28, 2022
@github-actions
Copy link

github-actions bot commented Nov 28, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 43s ⏱️ +3s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit ec215f5. ± Comparison against base commit 536218c.

♻️ This comment has been updated with latest results.

RyanHolstien
RyanHolstien approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@RyanHolstien RyanHolstien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we test out OTEL without the -all jar? Or is the -all jar now renamed to just .jar in the new version?

@david-leifker david-leifker merged commit ef9a280 into datahub-project:master Nov 29, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@david-leifker @cccs-Dustin
fix(verions): Update opentelemetry and updates from pr-5239 (datahub-…
80ca08f 
…project#6563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@david-leifker @RyanHolstien