fix(ingest): set DataProcessInstance created ts to start time #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the dataJob runs tab (which shows dataProcessInstances), the "Time" column displays the `dataProcessInstanceProperties.created` timestamp. This change makes the emitter actually show the real start times when provided.
github-actions
bot
added
the
ingestion
jjoyce0510
reviewed
Nov 29, 2022
| @@ -164,7 +164,7 @@ def emit_process_start( | |||
| for mcp in template_object.generate_mcp(): | |||
| self._emit_mcp(mcp, emitter, callback) | |||
|
|
|||
| for mcp in self.generate_mcp(): | |||
| for mcp in self.generate_mcp(created_ts_millis=start_timestamp_millis): | |||
There was a problem hiding this comment.
This should have been there in the first place! Nice change.
jjoyce0510
approved these changes
Nov 29, 2022
|
Our tests ignore the timestamps so they remain unchanged. At some point we will need to add proper tests for this stuff though |
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the dataJob runs tab (which shows dataProcessInstances), the "Time" column displays the
dataProcessInstanceProperties.createdtimestamp. This change makes the emitter actually show the start times when provided.Slack ref: https://datahubspace.slack.com/archives/CUMUWQU66/p1669108847712609?thread_ts=1669020230.808929&cid=CUMUWQU66
Checklist