Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): remove inconsistency check command #6569

Merged
merged 2 commits into from
Nov 29, 2022
Merged

feat(cli): remove inconsistency check command #6569

merged 2 commits into from
Nov 29, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata labels Nov 29, 2022
@github-actions
Copy link

github-actions bot commented Nov 29, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 1m 12s ⏱️ + 2m 45s
   765 tests ±0     763 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 532 runs  ±0  1 527 ✔️ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit 6adad88. ± Comparison against base commit fb2ffe4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 29, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 36s ⏱️ -2s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 6adad88. ± Comparison against base commit fb2ffe4.

♻️ This comment has been updated with latest results.

hsheth2
hsheth2 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Was this mainly part of a code cleanup effort or was it causing issues?

@jjoyce0510 jjoyce0510 merged commit 329ecb8 into datahub-project:master Nov 29, 2022
@anshbansal
Copy link
Collaborator Author

Code cleanup @hsheth2 . No issues caused.

@anshbansal anshbansal deleted the aseem-remove-inconsistency-command branch November 30, 2022 09:48
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@anshbansal @cccs-Dustin
feat(cli): remove inconsistency check command (datahub-project#6569)
4c3337c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anshbansal @hsheth2 @jjoyce0510