Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): fix types changes in clickhouse sqlalchemy 0.2.3 #6572

Merged

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Nov 29, 2022

Due to this change in clickhouse-sqlalchemy version 2.3.0, DataHub field type for "DateTime" and "DateTime64" is incorrectly represented as DateType instead of TimeType.
To add more context, Clickhouse types DateTime and DateTime64 are subclassed from sqlalchemy Date type instead of DateTime type, hence the above change caused inconsistent types in DataHub.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 29, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 58s ⏱️
   765 tests    763 ✔️ 2 💤 0
1 532 runs  1 527 ✔️ 5 💤 0

Results for commit e1b298c.

@github-actions
Copy link

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 37s ⏱️ -7s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ±0 

Results for commit e1b298c. ± Comparison against base commit 1bb8be5.

Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit fb2ffe4 into datahub-project:master Nov 29, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants