Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): profiling - Profiling failed if column cardinality threw an error #6582

Merged
merged 1 commit into from
Dec 1, 2022
Merged

fix(ingest): profiling - Profiling failed if column cardinality threw an error #6582

merged 1 commit into from
Dec 1, 2022

Conversation

treff7es
Copy link
Contributor

Fix for UnboundLocalError: local variable 'nonnull_count' referenced before assignment error

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es treff7es changed the title fix(profiling) - Profiling failed if column cardinality threw an error fix(ingest): profiling - Profiling failed if column cardinality threw an error Nov 30, 2022
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 30, 2022
anshbansal
anshbansal approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 19s ⏱️
   765 tests    763 ✔️ 2 💤 0 ❌
1 532 runs  1 527 ✔️ 5 💤 0 ❌

Results for commit b76fbd0.

@github-actions
Copy link

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 56s ⏱️ +7s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit b76fbd0. ± Comparison against base commit f69b469.

@treff7es treff7es merged commit 72b95f2 into datahub-project:master Dec 1, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@treff7es @cccs-Dustin
fix(ingest): profiling - Profiling failed if column cardinality threw…
aaaecb8 
… an error datahub-project#6582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@treff7es @anshbansal @hsheth2