Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quickstart): add support for passing thru env vars needed by Sla… #6591

Merged
merged 3 commits into from
Dec 4, 2022
Merged

feat(quickstart): add support for passing thru env vars needed by Sla… #6591

merged 3 commits into from
Dec 4, 2022

Conversation

shirshanka
Copy link
Contributor

…ck, Teams actions

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Dec 1, 2022
jjoyce0510
jjoyce0510 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Dec 1, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 43s ⏱️ -1s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit d925417. ± Comparison against base commit 5937b35.

♻️ This comment has been updated with latest results.

@jjoyce0510
Copy link
Collaborator

@shirshanka looks like we need to regenerate the quickstart compose file..

@shirshanka shirshanka merged commit 4876fdd into datahub-project:master Dec 4, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@shirshanka @cccs-Dustin
feat(quickstart): add support for env vars for Slack, Teams actions (d…
492792f 
…atahub-project#6591)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shirshanka @jjoyce0510