feat(ingest): Support config variable for specifying a direct privat… #6609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
approved these changes
Dec 2, 2022
| raise ValueError( | ||
| f"'private_key_path' was none " | ||
| f"but should be set when using {v} authentication" | ||
| f"Both `private_key` and `private_key_path` are none. " |
There was a problem hiding this comment.
nit: i see that we're throwing the error below, but ideally we should just be doing the error checking in one place
There was a problem hiding this comment.
Yes. This is the main place I intend to keep error checking at. The assertion in below method was added primarily for linter.
There was a problem hiding this comment.
To remove the assert, we can add if.. elif.. , however assert seemed cleaner to me.
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e key
Checklist