Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/snowflake): support filtering by fully qualified schema_pattern #6611

Merged
merged 1 commit into from
Dec 5, 2022
Merged

feat(ingest/snowflake): support filtering by fully qualified schema_pattern #6611

merged 1 commit into from
Dec 5, 2022

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Dec 2, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   58m 50s ⏱️ - 1m 42s
   766 tests ±0     764 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 534 runs  ±0  1 529 ✔️ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit d317d83. ± Comparison against base commit fdcb731.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 2, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 43s ⏱️ -16s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit d317d83. ± Comparison against base commit fdcb731.

♻️ This comment has been updated with latest results.

hsheth2
hsheth2 approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hsheth2 hsheth2 changed the title feat(ingest): support filtering by fully qualified schema_pattern feat(ingest/snowflake): support filtering by fully qualified schema_pattern Dec 5, 2022
@hsheth2 hsheth2 merged commit e5a823e into datahub-project:master Dec 5, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@mayurinehate @cccs-Dustin
feat(ingest/snowflake): support filtering by fully qualified schema_p…
9bc191f 
…attern (datahub-project#6611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mayurinehate @hsheth2