Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ingest): remove feast-legacy #6661

Merged
merged 1 commit into from
Dec 6, 2022
Merged

chore(ingest): remove feast-legacy #6661

merged 1 commit into from
Dec 6, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 6, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata labels Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 0m 3s ⏱️
   766 tests    764 ✔️ 2 💤 0 ❌
1 534 runs  1 529 ✔️ 5 💤 0 ❌

Results for commit f13caff.

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Unit Test Results (build & test)

633 tests  ±0   629 ✔️ ±0   15m 53s ⏱️ +14s
162 suites ±0       4 💤 ±0 
162 files   ±0       0 ❌ ±0 

Results for commit f13caff. ± Comparison against base commit f2a83f3.

jjoyce0510
jjoyce0510 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thank you for handling this!

@jjoyce0510 jjoyce0510 merged commit fceef48 into datahub-project:master Dec 6, 2022
@hsheth2 hsheth2 deleted the feast-legacy branch December 6, 2022 23:56
hsheth2 added a commit to hsheth2/datahub that referenced this pull request Jan 9, 2023
@hsheth2
chore(ingest): finish removing feast-legacy
68cf4b2 
Follow up on datahub-project#6661, which was incomplete.
@hsheth2 hsheth2 mentioned this pull request Jan 9, 2023
Merged
5 tasks
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
chore(ingest): remove feast-legacy (datahub-project#6661)
f3935b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @jjoyce0510