Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): redshift - Redshift rework #6906

Merged
merged 83 commits into from
Apr 12, 2023

Conversation

treff7es
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 30, 2022
@hsheth2
Copy link
Collaborator

hsheth2 commented Mar 24, 2023

@treff7es looks like the docs site still doesn't like the redshift-usage-legacy fixes

Failed to process redshift-usage-legacy due to exception No module named 'datahub.ingestion.source.usage.redshift_usage'

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Patch coverage: 29.49% and project coverage change: -9.22 ⚠️

Comparison is base (1324231) 74.87% compared to head (3968cf5) 65.66%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6906      +/-   ##
==========================================
- Coverage   74.87%   65.66%   -9.22%     
==========================================
  Files         353      362       +9     
  Lines       35386    36340     +954     
==========================================
- Hits        26496    23861    -2635     
- Misses       8890    12479    +3589     
Flag Coverage Δ
pytest-testIntegration ?
pytest-testIntegrationBatch1 35.91% <22.48%> (-0.56%) ⬇️
pytest-testQuick 62.26% <29.49%> (-1.29%) ⬇️
pytest-testSlowIntegration 32.47% <22.48%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/src/datahub/ingestion/source/redshift/common.py 0.00% <0.00%> (ø)
...n/src/datahub/ingestion/source/redshift/lineage.py 0.00% <0.00%> (ø)
...n/src/datahub/ingestion/source/redshift/profile.py 0.00% <0.00%> (ø)
.../src/datahub/ingestion/source/redshift/redshift.py 0.00% <0.00%> (ø)
...ion/src/datahub/ingestion/source/sql/sql_config.py 97.10% <ø> (-1.45%) ⬇️
...tion/src/datahub/ingestion/source/sql/sql_utils.py 58.90% <25.00%> (-34.20%) ⬇️
...tahub/ingestion/source/redshift/redshift_schema.py 49.68% <49.68%> (ø)
...ion/src/datahub/ingestion/source/redshift/query.py 76.92% <76.92%> (ø)
...on/src/datahub/ingestion/source/redshift/report.py 95.65% <95.65%> (ø)
...ion/src/datahub/ingestion/source/redshift/usage.py 96.58% <96.58%> (ø)
... and 5 more

... and 75 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants