feat(ingest): add entity registry in codegen #6984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
jjoyce0510
reviewed
Jan 10, 2023
|
@jjoyce0510 updated the PR description on why this is useful |
jjoyce0510
reviewed
Jan 18, 2023
| "mxe/PlatformEvent.avsc", | ||
| "platform/event/v1/EntityChangeEvent.avsc", | ||
| "metadata/query/filter/Filter.avsc", # temporarily added to test reserved keywords support | ||
| def generate(entity_registry: str, schemas_path: str, outdir: str) -> None: |
There was a problem hiding this comment.
When folks have custom extensions to base entity registry, is the idea that they would have merged these in advanced?
There was a problem hiding this comment.
Yup
If they have custom extensions to the entity registry, they're almost certainly building this from source anyways, so it's an ok assumption to make
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Jan 18, 2023
Co-authored-by: Pedro Silva <pedro@acryl.io>
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Jan 18, 2023
Co-authored-by: Pedro Silva <pedro@acryl.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds information from the entity registry to the codegen system. Specifically, it adds a get_aspect_info() method to aspects that contains the entity name, docs and category annotations if available, and list of supported aspects.
Why is this useful? It sets up some interesting use cases in the future:
Checklist