feast(eso): rename topic #7029
feast(eso): rename topic #7029
Conversation
github-actions
bot
added
devops
| */ | ||
| record BuildIndicesHistoryEvent { | ||
| record DataHubUpgradeHistoryEvent { |
There was a problem hiding this comment.
In future my guess is we'd at the upgrade id in here right?
There was a problem hiding this comment.
(cuz currently we don't know which upgrade id this is for)
| */ | ||
| record BuildIndicesHistoryEvent { | ||
| record DataHubUpgradeHistoryEvent { | ||
|
|
||
| /** | ||
| * Version of the build |
There was a problem hiding this comment.
Why is version of the build necessary? In the rest of upgrade fw we have a concept of a "version of an upgrade". Would be useful to do something similar here
There was a problem hiding this comment.
Forgot to change the doc here, yeah it can be version of upgrade instead. The version tag is used so that the distributed components can understand everything is up to date. If the upgrade ID is something local to GMS it can't be used unless all components can consistently generate it in the same way.
.../mae-consumer/src/main/java/com/linkedin/metadata/kafka/boot/MCLBootstrapManagerFactory.java
Show resolved
Hide resolved
docker/quickstart/docker-compose.consumers-without-neo4j.quickstart.yml
Outdated
Show resolved
Hide resolved
docker/quickstart/docker-compose-without-neo4j-m1.quickstart.yml
Outdated
Show resolved
Hide resolved
...ervice/factories/src/main/java/com/linkedin/metadata/boot/steps/WaitForBuildIndicesStep.java
Show resolved
Hide resolved
| @@ -8,7 +8,7 @@ | |||
| @RequiredArgsConstructor | |||
| public class WaitForBuildIndicesStep implements BootstrapStep { | |||
There was a problem hiding this comment.
Minor: Make this an UpgradeStep if you want it to be written to MySQL after the first execution (it will also be skipped thereafter without needing to check kafka at all)
…ahub into feat/eso-rename
jjoyce0510
merged commit f3a5ad2
into
datahub-project:feat/elasticsearch-optimization-ext
Haven't tested, but pretty sure I got all the spots