refactor(ingest/athena): Replace s3_staging_dir parameter in Athena source with query_result_location
#7044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
bossenti
changed the title
s3_staging_dir parameter in Athena source with query_result_locations3_staging_dir parameter in Athena source with query_result_location
jjoyce0510
approved these changes
Jan 17, 2023
|
Let's wait for CI to pass first. |
|
Thanks for reviewing @jjoyce0510! |
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Jan 18, 2023
… source with `query_result_location` (datahub-project#7044) Co-authored-by: John Joyce <john@acryl.io>
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Jan 18, 2023
… source with `query_result_location` (datahub-project#7044) Co-authored-by: John Joyce <john@acryl.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an outcome of this Slack discussion.
It deprecates the parameter
s3_staging_dirin the Athena source and introducesquery_result_locationinstead.Downwards compatibility is ensured.
While writing the tests I didn't found an integration test for Athena.
If someone could provide me with some background information about writing integration tests for sources, I could add one to this PR.
Checklist