feat(ingest): fix handling of unions with aliases in post restli conversion #7058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
shirshanka
reviewed
Jan 17, 2023
| } | ||
| if ( | ||
| not pre | ||
| and set(obj.keys()) == {"cost", "costType"} |
There was a problem hiding this comment.
will this check continue to work if we evolve the schema of the CostModel in the future?
There was a problem hiding this comment.
no they won't work
I've added a bit more testing that will alert us any time the assumptions made here are violated by changes in the model
jjoyce0510
reviewed
Jan 17, 2023
jjoyce0510
reviewed
Jan 17, 2023
hsheth2
changed the title
jjoyce0510
reviewed
Jan 18, 2023
| new_key: _json_transform(value, from_pattern, to_pattern, pre=pre) | ||
| } | ||
|
|
||
| if pre: |
There was a problem hiding this comment.
Minor - we can address later. "pre" is a somewhat general name for this argument. It would be useful to change name or provide docs about it as method docs for the json_transform method.
jjoyce0510
reviewed
Jan 18, 2023
| # Note that "CostCostClass" is the only usage of a union with aliases in our | ||
| # current PDL / metadata model, so the below hardcoding works. | ||
| # Because this method is brittle and prone to becoming stale, we validate | ||
| # the aforementioned assumption in our tests. |
There was a problem hiding this comment.
Awesome call out and docs. Thank you
jjoyce0510
reviewed
Jan 18, 2023
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Jan 18, 2023
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist