fix(docker): support non amd64 dockerize in setup containers

[tonycsoka]

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

This fixes an issue where the amd64 binary version of dockerize was being used to start the mysql-setup and elasticsearch-setup containers, regardless of the architecture of image being being, causing datahub docker quickstart to fail on arm64. Instead, this fix builds dockerize in a staged build, and uses the resultant binary in the final image. Tried first by downloading the gzipped Source asset from the dockerize repo, but this did not include all needed files for a build, hence going for a git clone solution.

[pedro93]

Hello @tonycsoka

First of all, thank you for making a contribution to DataHub! We appreciate folks who actively try to improve the project.

Second, for this PR to be accepted could you please update the PR title and description to match our guidelines? See here: https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md#commit-message-format

In order to ensure your PR gets merged we would highly recommend adding a description to your PR that describes the problem you are trying to solve, how did you did it and any considerations reviewers and/or users of this feature may need to have.

[tonycsoka]

Hello @tonycsoka

First of all, thank you for making a contribution to DataHub! We appreciate folks who actively try to improve the project.

Second, for this PR to be accepted could you please update the PR title and description to match our guidelines? See here: https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md#commit-message-format

In order to ensure your PR gets merged we would highly recommend adding a description to your PR that describes the problem you are trying to solve, how did you did it and any considerations reviewers and/or users of this feature may need to have.

Thanks @pedro93, how's that for you.

[szalai1]

go install github.com/jwilder/dockerize@latest

might be simpler

[pedro93]

For consistent behaviour please take the dockerize version to a well tested version.

[tonycsoka]

sorted on the branch, not too familiar with the suggestion from @szalai1 as I'm a go virgin, but for now it'll grab the specified tag

[szalai1]

@tonycsoka , you don't need to clone and run all those commands to set up and build the binary, you can just run go install packagename@version and it will install it.

[tonycsoka]

@pedro93 OK, hopefully that should be it, moved directly to go install github.com/jwilder/dockerize@... as per @szalai1

[pedro93]

@tonycsoka did you try Peter's suggestion with go install github.com/jwilder/dockerize@latest rather than git cloning a repo?

[tonycsoka]

@tonycsoka did you try Peter's suggestion with go install github.com/jwilder/dockerize@latest rather than git cloning a repo?

Not yet, there's a little issue in that v0.6.1 of dockerize used this system called glock for dependency management which I'm looking at

[pedro93]

LGTM! Thank you for taking care of the review concerns. Once CI is green I think we can merge this.

[tonycsoka]

LGTM! Thank you for taking care of the review concerns. Once CI is green I think we can merge this.

Great and have a fine weekend!

[tonycsoka]

LGTM! Thank you for taking care of the review concerns. Once CI is green I think we can merge this.

@pedro93 Are those smoke tests a little delicate, can't see why this change would cause an issue and we have 2 different failures on separate CI runs?

[pedro93]

Yes our tests are a little flaky sometimes when big changes to the UI happen. CI was failing due to another issue that got fixed since. Merged your PR. Thank you for the contribution!