fix(kafka-setup): Make topic name consistent with other images #7103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
david-leifker
approved these changes
Jan 23, 2023
jjoyce0510
reviewed
Jan 23, 2023
They are not. Folks with custom topic names will have to change the environment variable names they are using to set names. This PR makes that name consistent for all components. Kafka-setup job was the outlier using inconsistent env var names compared to GMS & standalone consumers. I have made a note about this in updating-datahub.md |
jjoyce0510
reviewed
Jan 24, 2023
docs/how/updating-datahub.md
Outdated
| @@ -6,6 +6,9 @@ This file documents any backwards-incompatible changes in DataHub and assists pe | |||
|
|
|||
| ### Breaking Changes | |||
|
|
|||
| - #7103 This should only impact users who have configured explicit non-default names for DataHub's Kafka topics. The environment variables used to configure Kafka topics for DataHub used in the `kafka-setup` docker image have been updated to be in-line with other DataHub components, for more info see our docs on [Configuring Kafka in DataHub | |||
| ](https://datahubproject.io/docs/how/kafka-config). They have been suffixed with `_TOPIC`. This change should not affect any user who is using default Kafka names. | |||
There was a problem hiding this comment.
they have been suffixed with _TOPIC_NAME right?
There was a problem hiding this comment.
Before they were suffixed with _TOPIC, now it's _TOPIC_NAME
jjoyce0510
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist