Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(models): Replaces non-ASCII charactes in pdl files with ASCII c… #7105

Merged

Conversation

nmbryant
Copy link
Contributor

…haracters

Our team ran into some issues publishing the avro schema via Github actions due to non-ASCII characters in some of the pdl files. This PR replaces the non-ASCII characters with ASCII characters in the models.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@jjoyce0510 jjoyce0510 added the platform PR-s that make changes to core parts of the platform label Jan 23, 2023
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve, but can you explain exactly what the issue was? Why are non-ascii characters failing?

@jjoyce0510 jjoyce0510 merged commit dbc89c8 into datahub-project:master Jan 24, 2023
@nmbryant
Copy link
Contributor Author

Thanks for merging this. With our setup, the GMS is not able to publish the schema if detects a difference in the schema when an object is updated so we publish the schema via Github Actions. When the project was built in Actions, the generated files had unknown characters for the characters in this PR and it published that. Because of that, the GMS would detect a difference and try to publish the schema and fail. We were able to get the workflow working properly by adding a flag to the build command, but figured that changing the characters to ASCII might prevent someone else from running into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform PR-s that make changes to core parts of the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants