feat(ui) Build entity doesn't exist page for entity profiles #7150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscollins3456
changed the title
jjoyce0510
reviewed
Jan 27, 2023
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Jan 27, 2023
...hql-core/src/main/java/com/linkedin/datahub/graphql/types/dataset/mappers/DatasetMapper.java
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Jan 27, 2023
...hql-core/src/main/java/com/linkedin/datahub/graphql/types/dataset/mappers/DatasetMapper.java
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Jan 27, 2023
jjoyce0510
reviewed
Jan 27, 2023
| @@ -49,6 +49,10 @@ export default function EmbeddedProfile<T>({ urn, entityType, getOverridePropert | |||
| const { entityData, dataPossiblyCombinedWithSiblings, dataNotCombinedWithSiblings, loading, refetch } = | |||
| useGetDataForProfile({ urn, entityType, useEntityQuery, getOverrideProperties }); | |||
|
|
|||
| if (entityData?.exists === false) { | |||
jjoyce0510
reviewed
Jan 27, 2023
jjoyce0510
reviewed
Jan 27, 2023
jjoyce0510
approved these changes
Jan 27, 2023
Shoot I just completely forgot to push up my last commit adding this to the regular profie! |
jjoyce0510
approved these changes
Jan 27, 2023
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the embedded profile for the chrome extension as well as any entity profile, we want to show a page saying that an entity doesn't exist in datahub if that's the case instead of pretending like we know about the entity and showing a bare bones page (like we do in the main app).
This adds a new
existsfield on entities that you can query in graphql. It reuses an existingEntityExistsResolverthat was meant as its own endpoint with aurnin the params, but I repurpose it to get the urn from the source entity if it's not in the params so it can be used for both purposes.Here's what the page looks like for embedded profiles:
and for regular profiles:
Checklist