refactor(ui ingest): Allow enabling / disabling ingestion schedule easily #7162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscollins3456
approved these changes
Jan 30, 2023
| }; | ||
| updateState(newState); | ||
| } | ||
| console.log(state); |
There was a problem hiding this comment.
can remove this bad boy
danielcmessias
pushed a commit
to danielcmessias/datahub
that referenced
this pull request
Feb 1, 2023
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've received feedback that clearing a schedule for an ingestion run is non-obvious. In this PR, we introduce a button for explicitly enabling or disabling scheduling of an ingestion source. We also remove the confusing "Skip" button.
Also fixed naming consistency issues, moving from "Execution" to "Ingestion" vocab.
Status
Ready for review
Screenshots
Checklist