Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): fix issue in glue tests #7185

Merged
merged 2 commits into from
Jan 31, 2023
Merged

fix(ingest): fix issue in glue tests #7185

merged 2 commits into from
Jan 31, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 31, 2023

Regression from #7158, which wasn't detected because CI wasn't running our tests correctly.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 mentioned this pull request Jan 31, 2023
Merged
5 tasks
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 31, 2023
@jjoyce0510 jjoyce0510 enabled auto-merge (squash) January 31, 2023 05:50
jjoyce0510
jjoyce0510 approved these changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI passes.

@jjoyce0510 jjoyce0510 merged commit db1a0f1 into datahub-project:master Jan 31, 2023
danielcmessias pushed a commit to danielcmessias/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @danielcmessias
fix(ingest): fix issue in glue tests (datahub-project#7185)
3331106
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@hsheth2
fix(ingest): fix issue in glue tests (datahub-project#7185)
e1a3cdd
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@hsheth2
fix(ingest): fix issue in glue tests (datahub-project#7185)
35b95e1
@hsheth2 hsheth2 deleted the glue-fix-tests branch February 14, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @jjoyce0510