fix(ingest/tableau): handle missing query in tableau views #7186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Darn you beat me to it. I came here to submit the easy PR. You're amazing @hsheth2 ! |
github-actions
bot
added
the
ingestion
| @@ -893,7 +893,7 @@ def emit_custom_sql_datasources(self) -> Iterable[MetadataWorkUnit]: | |||
| view_properties = ViewPropertiesClass( | |||
| materialized=False, | |||
| viewLanguage="SQL", | |||
| viewLogic=clean_query(csql.get("query", "")), | |||
| viewLogic=clean_query(csql.get("query") or ""), | |||
There was a problem hiding this comment.
Suggestion: Let's just skip adding viewProperties to dataset aspects if custom SQL query is not available.
|
Hey - can we get this merged 🙏 |
mayurinehate
approved these changes
Feb 3, 2023
jjoyce0510
approved these changes
Feb 6, 2023
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7182
Checklist