fix(ingest/tableau): show warning about token expiry for PATs #7187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
mayurinehate
approved these changes
Jan 31, 2023
| @@ -199,8 +199,15 @@ def make_tableau_client(self) -> Server: | |||
| server.auth.sign_in(authentication) | |||
| return server | |||
| except ServerResponseError as e: | |||
| if isinstance(authentication, PersonalAccessTokenAuth): | |||
| # Docs on token expiry in Tableau: | |||
| # https://help.tableau.com/current/server/en-us/security_personal_access_tokens.htm#token-expiry | |||
There was a problem hiding this comment.
Thanks for adding link to related tableau doc.
treff7es
approved these changes
Jan 31, 2023
danielcmessias
pushed a commit
to danielcmessias/datahub
that referenced
this pull request
Feb 1, 2023
ericyomi
pushed a commit
to ericyomi/datahub
that referenced
this pull request
Feb 8, 2023
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in https://datahubspace.slack.com/archives/C02GBGG90CU/p1675104815475809?thread_ts=1669815878.875039&cid=C02GBGG90CU
Checklist