Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest-idp): emit empty GroupMembership when there are no groups #7196

Merged
merged 3 commits into from
Feb 2, 2023
Merged

fix(ingest-idp): emit empty GroupMembership when there are no groups #7196

merged 3 commits into from
Feb 2, 2023

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Jan 31, 2023 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 31, 2023
hsheth2
hsheth2 previously requested changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are failing

metadata-ingestion/src/datahub/ingestion/source/identity/okta.py Show resolved Hide resolved
@jjoyce0510
Copy link
Collaborator

(Tests still failing)

@aditya-radhakrishnan aditya-radhakrishnan force-pushed the ar--01-30-empty-group-membership branch 3 times, most recently from 8e1faad to ebed967 Compare February 1, 2023 22:29
@aditya-radhakrishnan aditya-radhakrishnan dismissed hsheth2’s stale review February 2, 2023 19:56

The changes have been made

@aditya-radhakrishnan aditya-radhakrishnan merged commit bd17dde into datahub-project:master Feb 2, 2023
@aditya-radhakrishnan aditya-radhakrishnan deleted the ar--01-30-empty-group-membership branch February 2, 2023 19:56
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@aditya-radhakrishnan @jjoyce0510
fix(ingest-idp): emit empty GroupMembership when there are no groups (d…
220338d 
…atahub-project#7196)

Co-authored-by: John Joyce <john@acryl.io>
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@aditya-radhakrishnan @jjoyce0510
fix(ingest-idp): emit empty GroupMembership when there are no groups (d…
f802b28 
…atahub-project#7196)

Co-authored-by: John Joyce <john@acryl.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 left review comments

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aditya-radhakrishnan @jjoyce0510 @hsheth2