Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) Increase the number of assertions that we query for in tab #7215

Conversation

chriscollins3456
Copy link
Collaborator

We have an issue raised that explains how we don't fetch all assertions in the Validations tab so the number displayed next to the entity name doesn't match what we show in the validations tab.

The quick fix here is to increase the hardcoded number from 100 -> 1000 assertions we get. This query is run only in the validations tab so it won't increase the latency of dataset page load overall.

The better solution, in my opinion, is to keep total as 100 but add pagination to the tab. We would need to change how we generate the summary to show how many are passing out of the total on that page as well. This isn't a huge lift, but bigger than I was willing to commit at the moment, so I created a Linear ticket for it and made this quick fix to solve the immediate problem for peope.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants