Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): redshift # build late binding view lineage when sql written in upper case #7223

Merged
merged 1 commit into from Feb 2, 2023
Merged

fix(ingest): redshift # build late binding view lineage when sql written in upper case #7223

merged 1 commit into from Feb 2, 2023

Conversation

looppi
Copy link
Contributor

@looppi looppi commented Feb 2, 2023

Change like to ilike as sometimes SQL is written in upper case.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 2, 2023
mayurinehate
mayurinehate approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshbansal anshbansal added the community-contribution PR or Issue raised by member(s) of DataHub Community label Feb 2, 2023
treff7es
treff7es approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for the fix

@treff7es treff7es merged commit ba7b9d0 into datahub-project:master Feb 2, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@looppi
fix(ingest): redshift # build late binding view lineage when sql writ…
4424329 
…ten in upper case (datahub-project#7223)
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@looppi
fix(ingest): redshift # build late binding view lineage when sql writ…
c0237ce 
…ten in upper case (datahub-project#7223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

@mayurinehate mayurinehate mayurinehate approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@looppi @treff7es @mayurinehate @anshbansal