-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Timeline API supports Glossary Terms now #7229
feat(api): Timeline API supports Glossary Terms now #7229
Conversation
metadata-io/src/main/java/com/linkedin/metadata/timeline/TimelineServiceImpl.java
Outdated
Show resolved
Hide resolved
metadata-io/src/main/java/com/linkedin/metadata/timeline/TimelineServiceImpl.java
Outdated
Show resolved
Hide resolved
...java/com/linkedin/metadata/timeline/eventgenerator/GlossaryTermInfoChangeEventGenerator.java
Outdated
Show resolved
Hide resolved
...java/com/linkedin/metadata/timeline/eventgenerator/GlossaryTermInfoChangeEventGenerator.java
Outdated
Show resolved
Hide resolved
...java/com/linkedin/metadata/timeline/eventgenerator/GlossaryTermInfoChangeEventGenerator.java
Outdated
Show resolved
Hide resolved
...java/com/linkedin/metadata/timeline/eventgenerator/GlossaryTermInfoChangeEventGenerator.java
Outdated
Show resolved
Hide resolved
Thank you for feedback. |
...java/com/linkedin/metadata/timeline/eventgenerator/GlossaryTermInfoChangeEventGenerator.java
Outdated
Show resolved
Hide resolved
import static com.linkedin.metadata.timeline.eventgenerator.EditableDatasetPropertiesChangeEventGenerator.*; | ||
|
||
|
||
public class GlossaryTermInfoChangeEventGenerator extends EntityChangeEventGenerator<GlossaryTermInfo> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would recommend adding a unit test for this class!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add a backlog item to add a test for this and Datasets as well. Looks like we don't have one on it either. I think we can get this in though unless you want to block on that.
…7229) Co-authored-by: RyanHolstien <RyanHolstien@users.noreply.github.com> Co-authored-by: Shirshanka Das <shirshanka@apache.org>
…7229) Co-authored-by: RyanHolstien <RyanHolstien@users.noreply.github.com> Co-authored-by: Shirshanka Das <shirshanka@apache.org>
Timeline API is expanded with Glossary Terms support.
Checklist