Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): update message when pulling docker images #7241

Merged

Conversation

mayurinehate
Copy link
Collaborator

Running datahub docker quickstart pulls required docker images from docker repository. Some of the images have size in GBs. For example - datahub-actions image is ~3.7GB

Downloading all images may take a while (a few minutes to a few hours), depending on network bandwidth. This PR updates the message to notify users of potentially longer wait time.

Earlier, we used to see the progress in pulling images through docker command output. However, this is now run in quiet mode (PR)

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 3, 2023
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 389aa8c into datahub-project:master Feb 6, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
…7241)

Co-authored-by: Pedro Silva <pedro@acryl.io>
Co-authored-by: Aseem Bansal <asmbansal2@gmail.com>
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
…7241)

Co-authored-by: Pedro Silva <pedro@acryl.io>
Co-authored-by: Aseem Bansal <asmbansal2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants