Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(access): move heading above the images #7291

Merged
merged 1 commit into from
Feb 9, 2023
Merged

doc(access): move heading above the images #7291

merged 1 commit into from
Feb 9, 2023

Conversation

anshbansal
Copy link
Collaborator

Makes more sense to have heading above the image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the docs Issues and Improvements to docs label Feb 9, 2023
aditya-radhakrishnan
aditya-radhakrishnan approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aditya-radhakrishnan aditya-radhakrishnan merged commit ed5d66a into master Feb 9, 2023
@aditya-radhakrishnan aditya-radhakrishnan deleted the aseem-fix-confusing-doc branch February 9, 2023 22:38
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@anshbansal
doc(access): move heading above the images (datahub-project#7291)
77e9551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

Assignees
No one assigned
Labels
docs Issues and Improvements to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anshbansal @aditya-radhakrishnan