feat: add chart entities to similar browsepath as dashboards #7293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
anshbansal
added
the
community-contribution
|
Thanks for the PR @looppi ! We are reviewing on our side. On the surface looking good |
jjoyce0510
approved these changes
Feb 17, 2023
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
…datahub-project#7293) Co-authored-by: John Joyce <john@acryl.io>
yoonhyejin
pushed a commit
that referenced
this pull request
Mar 3, 2023
…#7293) Co-authored-by: John Joyce <john@acryl.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ingested workspaces have multiple reports in them, usually the result is that there are a ton of ingested chart entities. Although common use case might not be to find report or datasource of a report by finding the chart first, I think it makes sense to expand similar behavior of browsepaths as the current implementation has on dashboards.
Checklist