fix(ui): fix styling on sign up and reset screens #7301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
44
to
46
| .ant-input-affix-wrapper-status-error:not(.ant-input-affix-wrapper-disabled):not(.ant-input-affix-wrapper-borderless).ant-input-affix-wrapper, | ||
| .ant-input-affix-wrapper-status-error:not(.ant-input-affix-wrapper-disabled):not(.ant-input-affix-wrapper-borderless).ant-input-affix-wrapper:hover { | ||
| background-color: transparent; | ||
| } |
There was a problem hiding this comment.
woah haha is there a simpler way to set this background color?
There was a problem hiding this comment.
It has been simplified!
Comment on lines
+225
to
+228
| fullName: string; | ||
| email: string; | ||
| password: string; | ||
| confirmPassword: string; | ||
| title: string; |
There was a problem hiding this comment.
just curious why the type casting here and above is necessary?
There was a problem hiding this comment.
TS was throwing an error for me, I think because it can't detect that the styled Form.Item is no longer a Form.Item
aditya-radhakrishnan
force-pushed
the
ar--02-09-fix_sign_up_and_reset_screens_styling
branch
from
6811448
to
cec4716
Compare
aditya-radhakrishnan
force-pushed
the
ar--02-09-fix_sign_up_and_reset_screens_styling
branch
from
cec4716
to
53f0071
Compare
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Before
After
Checklist