-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gradle): fix gradle command referenced in docs #7318
Merged
david-leifker
merged 9 commits into
datahub-project:master
from
david-leifker:fix-gradle-mae-command
Feb 17, 2023
Merged
fix(gradle): fix gradle command referenced in docs #7318
david-leifker
merged 9 commits into
datahub-project:master
from
david-leifker:fix-gradle-mae-command
Feb 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bdcd2f
to
2d4b11b
Compare
jjoyce0510
reviewed
Feb 13, 2023
@@ -14,8 +14,10 @@ | |||
@SpringBootApplication(exclude = {ElasticsearchRestClientAutoConfiguration.class, CassandraAutoConfiguration.class, | |||
SolrHealthContributorAutoConfiguration.class}) | |||
@ComponentScan(basePackages = { | |||
"com.linkedin.gms.factory.kafka", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What were the implications of NOT having these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception when not enabling consumers.
jjoyce0510
reviewed
Feb 13, 2023
jjoyce0510
reviewed
Feb 13, 2023
RyanHolstien
approved these changes
Feb 16, 2023
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
yoonhyejin
pushed a commit
that referenced
this pull request
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mae/mce docs when run independently by gradle & fixes exception.
./gradlew :metadata-jobs:mae-consumer-job:bootRun
Command referenced here: https://datahubproject.io/docs/metadata-jobs/mae-consumer-job/
ERROR:
Checklist