Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gradle): fix gradle command referenced in docs #7318

Merged

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Feb 11, 2023

Fixes mae/mce docs when run independently by gradle & fixes exception.

./gradlew :metadata-jobs:mae-consumer-job:bootRun

Command referenced here: https://datahubproject.io/docs/metadata-jobs/mae-consumer-job/

ERROR:

***************************
APPLICATION FAILED TO START
***************************

Description:

Parameter 1 of constructor in com.linkedin.metadata.boot.kafka.DataHubUpgradeKafkaListener required a bean of type 'org.springframework.kafka.core.DefaultKafkaConsumerFactory' that could not be found.


Action:

Consider defining a bean of type 'org.springframework.kafka.core.DefaultKafkaConsumerFactory' in your configuration.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@@ -14,8 +14,10 @@
@SpringBootApplication(exclude = {ElasticsearchRestClientAutoConfiguration.class, CassandraAutoConfiguration.class,
SolrHealthContributorAutoConfiguration.class})
@ComponentScan(basePackages = {
"com.linkedin.gms.factory.kafka",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What were the implications of NOT having these?

Copy link
Collaborator Author

@david-leifker david-leifker Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception when not enabling consumers.

@david-leifker david-leifker merged commit 751289c into datahub-project:master Feb 17, 2023
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants