Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(elasticsearch): make alias creation atomic #7332

Merged
merged 3 commits into from
Feb 16, 2023
Merged

fix(elasticsearch): make alias creation atomic #7332

merged 3 commits into from
Feb 16, 2023

Conversation

david-leifker
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 13, 2023
@david-leifker david-leifker added devops PR or Issue related to DataHub backend & deployment and removed product PR or Issue related to the DataHub UI/UX labels Feb 14, 2023
RyanHolstien
RyanHolstien reviewed Feb 16, 2023
View reviewed changes
...io/src/main/java/com/linkedin/metadata/search/elasticsearch/indexbuilder/ESIndexBuilder.java
throw new RuntimeException(String.format("Reindex from %s to %s failed. Document count %s != %s", indexState.name(), tempIndexName,
documentCounts.getFirst(), documentCounts.getSecond()));
log.warn("Reindex retry timeout for {}.", indexState.name());
break;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems kind of dangerous to let it continue on after the reindex continues on, isn't it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is duplicated below and only if we explicitly enable clone & allow mismatch does this not just get thrown below line #297 (rethrow) or #290 (allowed condition)

@david-leifker david-leifker merged commit d765989 into master Feb 16, 2023
@david-leifker david-leifker deleted the elastisearch-atomic-alias branch February 16, 2023 20:17
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@david-leifker
fix(elasticsearch): make alias creation atomic (datahub-project#7332)
2a2854d
yoonhyejin pushed a commit that referenced this pull request Mar 3, 2023
@david-leifker
fix(elasticsearch): make alias creation atomic (#7332)
87999a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@pedro93 pedro93 Awaiting requested review from pedro93

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@david-leifker @RyanHolstien