-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tableau): make Tableau ingestor resilient to timeout exceptions #7333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treff7es
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the contribution
looppi
pushed a commit
to looppi/datahub
that referenced
this pull request
Feb 15, 2023
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
yoonhyejin
pushed a commit
that referenced
this pull request
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
ingestion
PR or Issue related to the ingestion of metadata
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running Tableau ingestor against Tableau instances containing thousands of charts/dashboards which change often (hence also stale entity removal handler issues many soft-deletes) there is a risk of idle time between the last call to Tableau REST API to get metadata and sign-out call done at the time the source is closed. That time mostly is taken by transfomers and stale entity removal handler. In my experience when running the ingestor the time can grow to be even more than 10 minutes. If the ingestor operates within stable network there shouldn't be any particular problem but it happens that in my use-cases many times connection (
requests.Session
http pool) is dropped during the idle time. Note that problem here arises from no activity between Tableau client and server and connection drop is not initiated from either side but rather by networking layer in between, so there is no easy way to keep connection active without explicitly issuing requests. Since the sign-out is anyway only an attempt to finish gracefully, I simply added no-op exception handling during the closing.Checklist