Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tableau): make Tableau ingestor resilient to timeout exceptions #7333

Merged
merged 9 commits into from
Feb 15, 2023

Conversation

skrydal
Copy link
Contributor

@skrydal skrydal commented Feb 14, 2023

While running Tableau ingestor against Tableau instances containing thousands of charts/dashboards which change often (hence also stale entity removal handler issues many soft-deletes) there is a risk of idle time between the last call to Tableau REST API to get metadata and sign-out call done at the time the source is closed. That time mostly is taken by transfomers and stale entity removal handler. In my experience when running the ingestor the time can grow to be even more than 10 minutes. If the ingestor operates within stable network there shouldn't be any particular problem but it happens that in my use-cases many times connection (requests.Session http pool) is dropped during the idle time. Note that problem here arises from no activity between Tableau client and server and connection drop is not initiated from either side but rather by networking layer in between, so there is no easy way to keep connection active without explicitly issuing requests. Since the sign-out is anyway only an attempt to finish gracefully, I simply added no-op exception handling during the closing.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 14, 2023
@anshbansal anshbansal added the community-contribution PR or Issue raised by member(s) of DataHub Community label Feb 14, 2023
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution

@treff7es treff7es merged commit 8207e46 into datahub-project:master Feb 15, 2023
looppi pushed a commit to looppi/datahub that referenced this pull request Feb 15, 2023
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants