Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cli): add check for missing init files #7378

Merged
merged 8 commits into from
Feb 20, 2023
Merged

test(cli): add check for missing init files #7378

merged 8 commits into from
Feb 20, 2023

Conversation

anshbansal
Copy link
Collaborator

CLI rc release failed because of missing __init__ file at https://github.com/acryldata/datahub/actions/runs/4222580108/jobs/7331259576. Adding check so the problem is detected during PRs itself.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata labels Feb 20, 2023
@hsheth2 hsheth2 changed the title fix(ingest): add missing package, add workflow to detect problem test(cli): add check for missing init files Feb 20, 2023
hsheth2
hsheth2 approved these changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment would help but lgtm otherwise

@anshbansal anshbansal merged commit 986086a into master Feb 20, 2023
@anshbansal anshbansal deleted the aseem-add-check-package-inits branch February 20, 2023 13:11
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@anshbansal
test(cli): add check for missing init files (datahub-project#7378)
91205e1
yoonhyejin pushed a commit that referenced this pull request Mar 3, 2023
@anshbansal
test(cli): add check for missing init files (#7378)
bcc5286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anshbansal @hsheth2