Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): exact match updates per review #7385

Merged
merged 17 commits into from
Feb 21, 2023
Merged

fix(search): exact match updates per review #7385

merged 17 commits into from
Feb 21, 2023

Conversation

david-leifker
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

david-leifker and others added 14 commits February 11, 2023 11:27
@david-leifker
gradle(development): add additional commands for development
fcacc60
@david-leifker
Merge branch 'master' into debugging-helpers
5f36408
@david-leifker
wip
017dc6c
@david-leifker
development(docs): Update documentation around development/debugging
de13bda
@david-leifker
Merge branch 'debugging-helpers' into adv-search-docs-and-tests
d9804c5
@david-leifker
Tests, user/group autocomplete
bfe2b44
@david-leifker
Merge remote-tracking branch 'origin/master' into adv-search-docs-and…
dad431b 
…-tests
@david-leifker
Merge branch 'master' into adv-search-docs-and-tests
e362fff
@david-leifker
Merge branch 'master' into adv-search-docs-and-tests
9d99d9f
@david-leifker
exact match weight
3776ea2
@david-leifker
Merge branch 'master' into adv-search-docs-and-tests
aad58e0
@david-leifker
fix tests
b632c4e
@david-leifker
fix(search): tweak exact match logic
fa9d6a8
@david-leifker
Merge remote-tracking branch 'origin/master' into adv-search-docs-and…
ce640f9 
…-tests

# Conflicts:
#	metadata-io/src/main/java/com/linkedin/metadata/search/elasticsearch/query/request/SearchQueryBuilder.java
#	metadata-io/src/main/java/com/linkedin/metadata/search/elasticsearch/query/request/SearchRequestHandler.java
#	metadata-io/src/test/java/com/linkedin/metadata/search/elasticsearch/query/request/SearchQueryBuilderTest.java
@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 20, 2023
@david-leifker
Copy link
Collaborator Author

Looking at the logs Trivy is not failing the build there is a project setting for this which is firing. Since it is configured the same as gms and gms is in the same project with the same settings, then I believe this could be merged to master without preventing a build.

@david-leifker david-leifker merged commit 36037cf into datahub-project:master Feb 21, 2023
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@david-leifker
fix(search): exact match updates per review (datahub-project#7385)
fd3942b
yoonhyejin pushed a commit that referenced this pull request Mar 3, 2023
@david-leifker
fix(search): exact match updates per review (#7385)
4af969b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@david-leifker @RyanHolstien