Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize updates #7387

Merged
merged 5 commits into from Feb 22, 2023
Merged

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Feb 20, 2023

  • Update dockerize's golang version
  • Normalize dockerize build across all images
  • Added postgres-setup module (not used by default)
  • Remove tar, vulnerability CVE-2022-48303

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Feb 20, 2023
@anshbansal
Copy link
Collaborator

Should we create a separate base image for all our images? It seems like we are re-building the same thing multiple times for no good reason. We only need to re-build this base image part when we are actually updating dockerize version. Or if we want to build this every time then we only need to do that once in the docker unified workflow if we move this out to a separate base image. This might also speed up our builds a bit.

@david-leifker
Copy link
Collaborator Author

david-leifker commented Feb 21, 2023

For the dockerize binary, not worth it building a base image for just that. It takes a few seconds to build it and it will keep the golang version updated from upstream so we wouldn't have to manually detect a need for an update. It is locked to the major version of golang.

@anshbansal anshbansal merged commit 571970c into datahub-project:master Feb 22, 2023
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
yoonhyejin pushed a commit that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants