fix(ingest/bigquery): Prefer parsed lineage for view over lineage from audit logs #7408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
Feb 22, 2023
Comment on lines
+720
to
727
| if parsed_view_upstreams: | ||
| # Override upstreams obtained by parsing audit logs | ||
| # as they may contain indirectly referenced tables | ||
| lineage_metadata[key] = set() | ||
| for table_id in parsed_view_upstreams: | ||
| lineage_metadata[key].add( | ||
| str(BigQueryTableRef(table_id).get_sanitized_table_ref()) | ||
| ) |
There was a problem hiding this comment.
We could replace this with a list (set) comprehension but either way is fine
oleg-ruban
pushed a commit
to RChygir/datahub
that referenced
this pull request
Feb 28, 2023
yoonhyejin
pushed a commit
that referenced
this pull request
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For scenarios such as
Table->View1->View2
Second is more accurate over first one. Hence in this PR we use SQL parsing lineage over lineage from audit logs, if SQL parsing lineage is available.
Another approach to fix this would be to fix point 1 above to not include tables that are not directly accessed in View DDL. However currently that happens only if config
lineage_use_sql_parseris enabledChecklist