Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/s3 ingestion enhancement to update schema from latest partition #7410

Conversation

nachiket-juneja
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

This PR is intended to enhance the S3 ingestion wherein data exists in the form of partitions. Currently, if there is any file that is present in the latest partition (day,month or year), the first file in the oldest partition gets picked. Due to this limitation, if there are any schema updates in the latest files, they are not visible on DataHub. We are trying to enhance this capability via this PR.

nachiket-juneja and others added 4 commits February 22, 2023 14:28
…eat/s3_ingestion_enhancement_to_update_schema_from_latest_partition
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 22, 2023
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es requested review from treff7es and removed request for treff7es February 24, 2023 09:59
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests seems to be failing

…eat/s3_ingestion_enhancement_to_update_schema_from_latest_partition
…est_partition' of https://github.com/nt-nuodata/datahub into feat/s3_ingestion_enhancement_to_update_schema_from_latest_partition
@nachiket-juneja
Copy link
Contributor Author

tests seems to be failing

Hey Tamas!
Not sure how the tests under the 'local' directory work, so wasn't sure what exactly they do and how to run them. Have corrected the 2 files and added the new one. Please take a look.

@anshbansal anshbansal added the community-contribution PR or Issue raised by member(s) of DataHub Community label Feb 27, 2023
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit e07cd20 into datahub-project:master Feb 28, 2023
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
…atahub-project#7410)

Co-authored-by: Prashant Singh Thakur <prashant.thakur@nucleusteq.com>
yoonhyejin pushed a commit that referenced this pull request Mar 3, 2023
…7410)

Co-authored-by: Prashant Singh Thakur <prashant.thakur@nucleusteq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants