Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ingest): lookml - fix up golden files in normalized form #7423

Merged
merged 1 commit into from
Feb 24, 2023
Merged

refactor(ingest): lookml - fix up golden files in normalized form #7423

merged 1 commit into from
Feb 24, 2023

Conversation

shirshanka
Copy link
Contributor

Normalizing golden files so that future diffs will be easier to understand.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 24, 2023
treff7es
treff7es approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shirshanka shirshanka merged commit 9575031 into datahub-project:master Feb 24, 2023
@shirshanka shirshanka deleted the lookml-goldens branch February 24, 2023 08:10
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@shirshanka
refactor(ingest): lookml - fix up golden files in normalized form (da…
d2aa34b 
…tahub-project#7423)
yoonhyejin pushed a commit that referenced this pull request Mar 3, 2023
@shirshanka
refactor(ingest): lookml - fix up golden files in normalized form (#7423
b9cb202 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shirshanka @treff7es