fix(ingest): lookml - add support for includes, extends, view_name i… #7428
Conversation
github-actions
bot
added
the
ingestion
| ) -> "LookerExplore": | ||
| view_names = set() | ||
|
|
||
| view_names: Set[str] = set() |
| joins = None | ||
| # always add the explore's name or the name from the from clause as the view on which this explore is built | ||
| view_names.add(dict.get("from", dict.get("name"))) | ||
| assert "name" in dict, "Explore doesn't have a name field, this isn't allowed" |
There was a problem hiding this comment.
asking to learn: if someone made a lookml like this, why isn't it allowed?
There was a problem hiding this comment.
would this lookml also not be accepted by looker or is a datahub specific requirement?
There was a problem hiding this comment.
the lkml parser will populate the name field in the dict based on the explore definition, that is the contract.
So, it's not about having a name field inside the explore definition... more like parsing the explore will populate the name field.
e.g.
explore: events {
... explore def
}
will result in a dictionary with the name key set to events
There was a problem hiding this comment.
ah I see, so we'd be looking at a malformed explore then if this wasn't parsed
| looker_viewfile_loader, | ||
| view_name, | ||
| reporter, | ||
| upstream_views: List[ProjectInclude] = [] |
| upstream_views.append( | ||
| ProjectInclude(project=info[0].project, include=view_name) | ||
| ) | ||
| if extends: |
| reporter.report_warning( | ||
| path, f"Failed to load {included_file} due to {e}" | ||
| ) | ||
| # continue in this case, as it might be better to load and resolve whatever we can |
| @@ -5,6 +5,7 @@ include: "bar.view.lkml" | |||
| include: "nested/*" | |||
| include: "liquid.view.lkml" | |||
| include: "ability.view.lkml" | |||
| include: "dataset_owners.explore.lkml" | |||
There was a problem hiding this comment.
thanks for adding a test
…n explore
Fixes a few issues with discovering views when navigating explores in the lookml source.
Checklist