Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lineage): Fixing Timeline Lineage Filters #7435

Merged
merged 1 commit into from
Feb 28, 2023
Merged

fix(lineage): Fixing Timeline Lineage Filters #7435

merged 1 commit into from
Feb 28, 2023

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Feb 24, 2023 •
edited
Loading

Summary

Few Changes

  • Fix the "runId" filter query to correctly use the keyword field (fixes Ingestion Run Summaries)
  • Fix the Lineage Tab and Lineage View Time Selectors to correctly filter by time. This correctly excludes edges where createdOn or updatedOn are both considered "missing" (null or 0).
  • Only add custom extracted createdOn / updatedOn to edges if they are non-zero.
  • Fix the UI side Lineage Graph View to always include the timestamp millis
  • Small UI Improvements to the Lineage Graph View

Screenshots

Screenshot 2023-02-24 at 4 44 59 PM

Screenshot 2023-02-24 at 4 41 01 PM

Status

Ready to review

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 24, 2023
@jjoyce0510
Fixing Timeline Lineage
d979f8c 
Fixing up tests
@jjoyce0510 jjoyce0510 force-pushed the jj--fix-timeline-lineage-filters branch from ea7ea5a to d979f8c Compare February 25, 2023 00:54
aditya-radhakrishnan
aditya-radhakrishnan approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jjoyce0510 jjoyce0510 merged commit d54e3b8 into datahub-project:master Feb 28, 2023
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@jjoyce0510
fix(lineage): Fixing Timeline Lineage Filters (datahub-project#7435)
a137004
yoonhyejin pushed a commit that referenced this pull request Mar 3, 2023
@jjoyce0510
fix(lineage): Fixing Timeline Lineage Filters (#7435)
25af41a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jjoyce0510 @aditya-radhakrishnan