chore(ingest/glue): cleanup deprecated underlying_platform config
#7449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been deprecated for 10 months now.
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
Feb 28, 2023
| @@ -168,26 +164,17 @@ def s3_client(self): | |||
| @validator("glue_s3_lineage_direction") | |||
| def check_direction(cls, v: str) -> str: | |||
| if v.lower() not in ["upstream", "downstream"]: | |||
| raise ConfigurationError( | |||
| raise ValueError( | |||
There was a problem hiding this comment.
How come you swap to ValueError here? Should all config validators raise ValueErrors?
There was a problem hiding this comment.
yes - with pydantic, you're supposed to raise ValueError or AssertionError
that way pydantic can (1) show if there are multiple validation issues and (2) shows the exact fields that failed validation alongside the errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been deprecated for 10 months now.
Checklist