Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/vertica): improve vertica type mappings #7459

Merged
merged 3 commits into from
Mar 7, 2023
Merged

feat(ingest/vertica): improve vertica type mappings #7459

merged 3 commits into from
Mar 7, 2023

Conversation

NotYuki
Copy link
Contributor

@NotYuki NotYuki commented Mar 1, 2023 •
edited
Loading

  1. Column data types map for Vertica DBMS
  2. dbt support for Vertica types.

For now, dbt produces a lot of warnings during ingestion of Vertica models like this:
unable to map type varchar(1024) to metadata schema
This PR eliminates such warnings.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 1, 2023
hsheth2
hsheth2 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2 hsheth2 changed the title feat(ingestion): Vertica types map & dbt-vertica sql types resolving feat(ingest/vertica): improve vertica type mappings Mar 7, 2023
@hsheth2 hsheth2 merged commit bb9835c into datahub-project:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NotYuki @hsheth2 @mlosnikov