tests(cypress): add improved Cypress tests for timeline lineage #7464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
Comment on lines
+93
to
+96
| Cypress.Commands.add("lineageTabClickOnUpstream", () => { | ||
| cy.get('[data-testid="lineage-tab-direction-select-option-downstream"] > b').click(); | ||
| cy.get('[data-testid="lineage-tab-direction-select-option-upstream"] > b').click(); | ||
| }) |
There was a problem hiding this comment.
so this clicks on both options?
There was a problem hiding this comment.
Yes since the downstream is the initial option, and we have to click on that to change to upstream. Does that make sense?
There was a problem hiding this comment.
ahh gotcha now it does
Comment on lines
+103
to
+104
| cy.visit( | ||
| `/tasks/${TRANSACTION_ETL_URN}/Lineage?filter_degree___false___EQUAL___0=1&is_lineage_mode=false&page=1&unionType=0&start_time_millis=${TIMESTAMP_MILLIS_14_DAYS_AGO}&end_time_millis=${TIMESTAMP_MILLIS_7_DAYS_AGO}` |
There was a problem hiding this comment.
if you didn't add these timestamps in the url here would we automatically add them from the FE?
There was a problem hiding this comment.
We would, this is just to make it easier to test
Comment on lines
-23
to
-24
| username: 'datahub', | ||
| password: 'datahub', |
There was a problem hiding this comment.
I think this accidentally made it in the views PR haha
chriscollins3456
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist