fix(ui) Standardize subtypes casing with View Definition tab #7477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscollins3456
requested review from
jjoyce0510,
aditya-radhakrishnan and
mayurinehate
asikowitz
approved these changes
Mar 2, 2023
Comment on lines
+103
to
+105
| dataset?.dataset?.subTypes?.typeNames | ||
| ?.map((t) => t.toLocaleLowerCase()) | ||
| .includes(SUBTYPES.VIEW.toLocaleLowerCase()) || false, |
There was a problem hiding this comment.
Is this for backwards compatibility? Seems simpler to change SUBTYPES.VIEW to View
There was a problem hiding this comment.
yeah for backwards compatibility! and just defensive in case it ever changes again, might as well compare them as a standard
aditya-radhakrishnan
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently introduced a change that will capitalize the first letter of subtype names. There's only one place in the frontend that I could find that would be affected and it's checking whether or not we show the "View Definition" tab for datasets. This will lowercase the subtype name and the name it checks against to make it standard.
Checklist